[U-Boot] [PATCH 4/9 v2] A driver for the S6E63D6 SPI display controller from Samsung

Guennadi Liakhovetski lg at denx.de
Thu Feb 5 17:46:37 CET 2009


On Thu, 5 Feb 2009, Anatolij Gustschin wrote:

> Guennadi Liakhovetski wrote:
> 
> > diff --git a/drivers/video/s6e63d6.c b/drivers/video/s6e63d6.c
> > new file mode 100644
> > index 0000000..4a59f05
> > --- /dev/null
> > +++ b/drivers/video/s6e63d6.c
> <snip>
> > +static int send_word(struct s6e63d6 *data, u8 rs, u16 word)
> > +{
> > +	u32 buf8 = 0x70 | data->id | (rs & 2);
> > +	u32 buf16 = cpu_to_le16(word);
> > +	u32 buf_in;
> > +	int err;
> > +
> > +	err = spi_xfer(data->slave, 8, &buf8, &buf_in, SPI_XFER_BEGIN);
> > +	if (err)
> > +		return err;
> > +	return spi_xfer(data->slave, 16, &buf16, &buf_in, SPI_XFER_END);
> 
> please add an empty line between two return statements here, Thanks!

Is this also required by CodingStyle?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list