[U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Thu Feb 5 20:52:07 CET 2009
On 20:13 Thu 05 Feb , Dirk Behme wrote:
> Dear Jean-Christophe,
>
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 06:53 Mon 02 Feb , Dirk Behme wrote:
>>> Update Pandora pin mux.
>> for what and why?
>
> Well, this is a very good example of why it is good to "use macros
> instead of hard coded values" :)
>
> Looking at the changes done in this patch, thanks to the macros used, it
> is obvious that here pulls are enabled for MMC data/cmd lines, and
> disabled for clock line. In case you are familiar with MMC hardware
> configuration, you should know why this is necessary.
so please update the commit message to explain it
Best Regards,
J.
More information about the U-Boot
mailing list