[U-Boot] [PATCH 9/9 v3] ARM: add an "eet" variant of the imx31_phycore board

[Jean-Christophe PLAGNIOL-VILLARD]

On 10:38 Fri 06 Feb     , Guennadi Liakhovetski wrote:
> The "eet" variant of the imx31_phycore board has an OLED display, using a
> s6e63d6 display controller on the first SPI interface, using GPIO57 as a
> chip-select for it. With this configuration you can display 256 colour BMP
> images in 16-bit RGB (RGB565) LCD mode.
> 
> Signed-off-by: Guennadi Liakhovetski <lg at denx.de>
> ---
> 
> Changes since v1: adjusted to reflect changes in earlier patches: add .id 
> field initialisation, configuration parameter renamed to CONFIG_S6E63D6.
> Changes since v2: fixed the left-over CONFIG_DISPLAY_S6E63D6 parameter.
> 
>  Makefile                              |    6 +++-
>  board/imx31_phycore/imx31_phycore.c   |   52 +++++++++++++++++++++++++++++++++
>  include/asm-arm/arch-mx31/mx31-regs.h |   16 ++++++++++
>  include/configs/imx31_phycore.h       |   23 ++++++++++++++
>  4 files changed, 96 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 787c5f2..6151e2c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3025,8 +3025,12 @@ apollon_config		: unconfig
>  imx31_litekit_config	: unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm1136 imx31_litekit NULL mx31
>  
> +imx31_phycore_eet_config \
>  imx31_phycore_config	: unconfig
> -	@$(MKCONFIG) $(@:_config=) arm arm1136 imx31_phycore NULL mx31
> +	@if [ -n "$(findstring imx31_phycore_eet_config,$@)" ]; then			\
> +		echo "#define CONFIG_IMX31_PHYCORE_EET" >> $(obj)include/config.h;	\
> +	fi
One question I'll send within few minutes the dcc support for arm
if you wish to use it in eet

you may create a
imx31_phycore_eet_dcc_config
config will you create a new if [ -n "(findstring imx31_phycore_eet_dcc_config...
to handle and so duplicate code

or just do this
	@if [ -n "$(findstring _eet_,$@)" ]; then			\
		echo "#define CONFIG_IMX31_PHYCORE_EET" >> $(obj)include/config.h;	\
	fi
	@if [ -n "$(findstring _dcc_,$@)" ]; then			\
		echo "#define CONFIG_DCC" >> $(obj)include/config.h;	\
	fi
??
I'll suggest to add a README file to describe the board and it's
specifications when it's possible maybe
> +	@$(MKCONFIG) -a imx31_phycore arm arm1136 imx31_phycore NULL mx31
>  
>  mx31ads_config		: unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads freescale mx31
> diff --git a/board/imx31_phycore/imx31_phycore.c b/board/imx31_phycore/imx31_phycore.c
> index 6b78194..9456468 100644
> --- a/board/imx31_phycore/imx31_phycore.c
> +++ b/board/imx31_phycore/imx31_phycore.c
> @@ -23,6 +23,7 @@
>  
>  
>  #include <common.h>
> +#include <s6e63d6.h>
>  #include <asm/arch/mx31.h>
>  #include <asm/arch/mx31-regs.h>
>  
> @@ -69,6 +70,57 @@ int board_init (void)
>  	return 0;
>  }
>  
> +#ifdef BOARD_LATE_INIT
> +int board_late_init(void)
> +{
> +#ifdef CONFIG_S6E63D6
> +	struct s6e63d6 data = {
> +		.cs = 2 | (57 << 8),
why??
> +		.bus = 0,
> +		.id = 0,
> +	};
> +	int ret;
> +
Best Regards,
J.