[U-Boot] [PATCH] at91: Factored out common serial hardware initialization

Wolfgang Denk wd at denx.de
Fri Feb 6 22:17:25 CET 2009


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090205130112.GC4580 at game.jcrosoft.org> you wrote:
>
> > Created a new function at91_serial_hw_init() which sets up the
> > dedicated PIO pins of several at91 SoC according to CONFIG_USARTx.
> > 
> > Please note that the used pins for serial communication varies on
> > different at91 SoC independently of the logic functionality equality
> > of the serial hardware.
> > 
> > Signed-off-by: Michael Roth <mroth at nessie.de>
> > ---
> I've send similar patch before please use it

Similar, but Michel's patch looks better to me. Fr example, he get's
rid of all the many #ifdef CONFIG_USARTx  which you still keep for no
good reason.

My vote is: please apply Michael's patch.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Plan to throw one away. You will anyway."
                              - Fred Brooks, "The Mythical Man Month"


More information about the U-Boot mailing list