[U-Boot] [PATCH 2/3][v3] dnet: driver for Dave DNET ethernet controller
Ilya Yanok
yanok at emcraft.com
Mon Feb 9 18:21:16 CET 2009
Hi Wolfgang,
Wolfgang Denk wrote:
>>>> + u32 TX_JUMBO_CNT;
>>>> + u32 TX_BYTE_CNT;
>>>> +} __attribute__((packed));
>>>>
>>>>
>>> Why is this packed? All fields are 32-bit aligned already.
>>>
>> Generally, I prefer declaring such structures with ((packed)) regardless
>> of if it's really do something. Just to show that it should be packed.
>>
>
> Can you please verify that it works as well without the "packed", and
> if it does (as expected) resubmit without it?
>
Ok. It works as expected. I'll post the updated patch soon.
Regards, Ilya.
More information about the U-Boot
mailing list