[U-Boot] [PATCH 17/40] Blackfin: overhaul i2c driver

[Timur Tabi]

On Fri, Jan 23, 2009 at 12:00 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> The current Blackfin i2c driver does not work properly with certain devices
> due to it breaking up transfers incorrectly.  This is a rewrite of the
> driver and relocates it to the newer place in the source tree.
>
> Also remove duplicated I2C speed defines in Blackfin board configs and
> disable I2C slave address usage since it isn't implemented.
>
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>

include/i2c.h still has this:

static inline void i2c_reg_write(u8 addr, u8 reg, u8 val)
{
...
#ifdef CONFIG_BLACKFIN
	/* This ifdef will become unneccessary in a future version of the
	 * blackfin I2C driver.
	 */
	i2c_write(addr, reg, 0, &val, 1);
#else
	i2c_write(addr, reg, 1, &val, 1);
#endif
}

There's a similar #ifdef in i2c_reg_read().  Are these #ifdefs still
necessary?  If so, could you modify your I2C driver so that they
aren't?  And then fix i2c.h as well?

-- 
Timur Tabi
Linux kernel developer at Freescale