[U-Boot] [PATCH 5/7] OMAP3: Add serial number based on die ID

[Dirk Behme]

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:14 Thu 05 Feb     , Dirk Behme wrote:
>> Dear Jean-Christophe,
>>
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> On 06:53 Mon 02 Feb     , Dirk Behme wrote:
>>>> Add serial number based on OMAP3 die ID.
>>>>
>>>> Signed-off-by: Dirk Behme <dirk.behme at googlemail.com>
>>>>
>>>> ---
>>>>  board/omap3/beagle/beagle.c            |    2 ++
>>>>  board/omap3/evm/evm.c                  |    2 ++
>>>>  board/omap3/overo/overo.c              |    2 ++
>>>>  board/omap3/pandora/pandora.c          |    2 ++
>>>>  board/omap3/zoom1/zoom1.c              |    1 +
>>>>  cpu/arm_cortexa8/omap3/sys_info.c      |   27 +++++++++++++++++++++++++++
>>>>  include/asm-arm/arch-omap3/cpu.h       |   13 +++++++++++++
>>>>  include/asm-arm/arch-omap3/omap3.h     |    1 +
>>>>  include/asm-arm/arch-omap3/sys_proto.h |    1 +
>>>>  9 files changed, 51 insertions(+)
>>>>
>>>> Index: u-boot-main/cpu/arm_cortexa8/omap3/sys_info.c
>>>> ===================================================================
>>>> --- u-boot-main.orig/cpu/arm_cortexa8/omap3/sys_info.c
>>>> +++ u-boot-main/cpu/arm_cortexa8/omap3/sys_info.c
>>>> @@ -36,6 +36,33 @@ static gpmc_csx_t *gpmc_cs_base = (gpmc_
>>>>  static sdrc_t *sdrc_base = (sdrc_t *)OMAP34XX_SDRC_BASE;
>>>>  static ctrl_t *ctrl_base = (ctrl_t *)OMAP34XX_CTRL_BASE;
>>>>  +/*****************************************************************
>>>> + * serial_num_r(void) - read and set serial number based on DIE ID
>>>> + *****************************************************************/
>>>> +void serial_num_r(void)
>>>> +{
>>>> +	ctrl_id_t *id_base = (ctrl_id_t *)OMAP34XX_ID_L4_IO_BASE;
>>>> +	char *uid_s, die_id[34];
>>>> +	u32 id[4];
>>>> +
>>>> +	memset(die_id, 0, sizeof(die_id));
>>>> +
>>>> +	uid_s = getenv("serial");
>>> why not call a cat a cat?
>> Why not give the cat a fitting name?
>>
>> The user gets a serial number, so we name it serial. How and where we  
>> get it from is hidden from user. It wouldn't help to name it "die ID"  
>> for user, nobody would know what this is. But serial number is clear to 
>> every body.
> serial number is board specific not CPU specific
> 
> when you product board and need to track then, you need to have a serial number that
> can not change even if you when the cpu.

Hmmh. With OMAP3 SoC we have a (serial) number we can easily access 
and report independent of board similar on all OMAP3 based boards. 
Yes, you are right, this is no board serial number. But as OMAP3 is 
something like 515-pin PBGA with .4mm/.65mm pitch, board and cpu (SoC) 
will most probably never be split/exchanged by 'normal' user. I really 
hope that for OMAP3 you can accept that we report OMAP3 serial number 
and not (maybe even not existing) board serial number?

Thanks

Dirk