[U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches

Mike Frysinger vapier at gentoo.org
Mon Feb 16 20:29:09 CET 2009


On Monday 16 February 2009 14:00:59 Scott Wood wrote:
> Mike Frysinger wrote:
> > at any rate, is there a define that can be keyed off of ?  CONFIG_HAS_FDT
> > or some such junk ?  then the behavior can be changed to like:
> > #ifndef CONFIG_HAS_FDT
> > 	/* ABI compat junk */
> > 	uchar bi_padding_was_enetaddr[6];
> > #endif
>
> Why not just leave the bd_t alone, until such a time as we can get rid
> of it altogether?
>
> Note that just because we support booting with device trees doesn't mean
> we don't also support booting legacy kernels.

the name has to go.  u-boot no longer uses that field and leaving it in will 
simply lead to code misusing it creeping it back into the tree.  whether you 
choose to force the warts on everyone is up to you ... i'm not a ppc consumer 
so i could care less.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090216/ffcbb7a6/attachment.pgp 


More information about the U-Boot mailing list