[U-Boot] [PATCH] 5/12 Multiadapter/multibus I2C, drivers part 2

Wolfgang Denk wd at denx.de
Mon Feb 16 22:48:44 CET 2009


Dear ksi at koi8.net,

In message <Pine.LNX.4.64ksi.0902121417310.21067 at home-gw.koi8.net> you wrote:
>
...
> -int i2c_read (uchar chip, uint addr, int alen, uchar * buffer, int len)
> +static int omap1510_i2c_read (uchar chip, uint addr, int alen, uchar * buffer, int len)
>  {
>  	int i;
>  
>  	if (alen > 1) {
> -		printf ("I2C read: addr len %d not supported\n", alen);
> +		printf ("%s: addr len %d not supported\n", __FUNCTION__, alen);
>  		return 1;
>  	}
>  
>  	if (addr + len > 256) {
> -		printf ("I2C read: address out of range\n");
> +		printf ("%s: address out of range\n", __FUNCTION__);

These are changes really to the worse: instead of

	I2C read: address out of range

we now get

	omap1510_i2c_read: address out of range

More difficult to read, higher memory footprint.

Please revert this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Today's robots are very primitive, capable of understanding  only  a
few  simple  instructions  such  as 'go left', 'go right', and 'build
car'."                                                  - John Sladek


More information about the U-Boot mailing list