[U-Boot] [PATCH] 7/12 Multiadapter/multibus I2C, drivers part 4

Wolfgang Denk wd at denx.de
Mon Feb 16 22:58:14 CET 2009


Dear ksi at koi8.net,

In message <Pine.LNX.4.64ksi.0902121423570.21067 at home-gw.koi8.net> you wrote:
>
> +#define I2C_SOFT_SEND_START(n) \
> +static void send_start##n(void) \
> +{ \
> +	I2C_SOFT_DECLARATIONS##n \
> +	I2C_DELAY##n; \
> +	I2C_SDA##n(1); \
> +	I2C_ACTIVE##n; \
> +	I2C_DELAY##n; \
> +	I2C_SCL##n(1); \
> +	I2C_DELAY##n; \
> +	I2C_SDA##n(0); \
> +	I2C_DELAY##n; \
>  }

Sorry, but that's becoming an unreadable mess. I don't think I'm going
to ACK such code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is common sense to take a method and try it. If it fails, admit it
frankly and try another. But above all, try something.
                                              - Franklin D. Roosevelt


More information about the U-Boot mailing list