[U-Boot] [PATCH 16/27] cpu/: get mac address from environment

Mike Frysinger vapier at gentoo.org
Tue Feb 17 00:56:59 CET 2009


On Monday 16 February 2009 17:52:55 Wolfgang Denk wrote:
> In message Mike Frysinger wrote:
> > --- a/cpu/mpc8260/ether_scc.c
> > +++ b/cpu/mpc8260/ether_scc.c
> > @@ -199,6 +199,7 @@ static int sec_init(struct eth_device *dev, bd_t
> > *bis) volatile immap_t *immr = (immap_t *)CONFIG_SYS_IMMR;
> >      scc_enet_t *pram_ptr;
> >      uint dpaddr;
> > +	uchar ea[6];
> >
> >      rxIdx = 0;
> >      txIdx = 0;
> > @@ -261,11 +262,10 @@ static int sec_init(struct eth_device *dev, bd_t
> > *bis) pram_ptr->sen_gaddr3 = 0x0;   /* Group Address Filter 3 (unused) */
> > pram_ptr->sen_gaddr4 = 0x0;   /* Group Address Filter 4 (unused) */
> >
> > -#  define ea bis->bi_enetaddr
> > +	eth_getenv_enetaddr("ethaddr", ea);
> >      pram_ptr->sen_paddrh = (ea[5] << 8) + ea[4];
> >      pram_ptr->sen_paddrm = (ea[3] << 8) + ea[2];
> >      pram_ptr->sen_paddrl = (ea[1] << 8) + ea[0];
> > -#  undef ea
>
> I see that we have bad indentations here, but please either provide a
> separate patch to fix the cosing style, or stich with your new code to
> the existing one.

oh, looks like this file uses sucky GNU style.  i didnt notice as i use 4-
spaced tabs.  i'll just change my tabs to match existing style as the cleanup 
would pretty much rewrite the whole file.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090216/58b8c8e2/attachment.pgp 


More information about the U-Boot mailing list