[U-Boot] [PATCH] bootm: Reduce the unnecessary memmove

[Wolfgang Denk]

Dear Minkyu Kang,

In message <499A676C.90207 at samsung.com> you wrote:
> Although load address and image start address are same address, bootm command does memmove.
> That is unnecessary memmove and can be taken few milliseconds (about 500 msec to 1000 msec).
> If reduce this memmove, we can reduce the boot time.

Please use shorer lines - 70 characters max.

> Please check this patch.
> 
> Thank you.
> Minkyu Kang.

Please move the comments and greetings...
> 
> Signed-off-by: Minkyu Kang <mk7.kang at samsung.com>
> ---

...below this "---" line as they would become part of the commit
message otherwise.

> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 07f6c6b..437f3f8 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -340,7 +340,8 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
>  		} else {
>  			printf ("   Loading %s ... ", type_name);
>  
> -			memmove_wd ((void *)load,
> +			if (load != image_start)
> +				memmove_wd ((void *)load,
>  				   (void *)image_start, image_len, CHUNKSZ);

Please use curly braces around the two-line statement; and increase
the indent for the last line.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
...when fits of creativity run strong, more than  one  programmer  or
writer  has  been  known to abandon the desktop for the more spacious
floor.                                             - Fred Brooks, Jr.