[U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init

Stefan Roese sr at denx.de
Tue Feb 17 14:42:01 CET 2009


On Tuesday 17 February 2009, Wolfgang Denk wrote:
> > > Well, there is a very small number of boards. Why cannot we have this
> > > change in one step, in one commit? Adding empty functions just to
> > > remove them later seems sub-optimal to me.
> >
> > in my mind, what i did is more logical.  i'll do whatever way you want
> > though. so just explicitly state "squash those changes into one even
> > though they touch a bunch of different places" and i'll happily do it.
>
> Hm... maybe somebody else comments?
>
> Stefan, Ben?

Personally I would prefer this "squashed" patch version as well. If possible 
in a "git-bisectable" version.

Thanks for all your effort here. Really appreciated.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list