[U-Boot] [PATCH 08/12] 83xx, kmeter: QE_ENET10 errata for Silicon Revision 2.1

Scott Wood scottwood at freescale.com
Tue Feb 17 18:51:43 CET 2009


On Mon, Feb 16, 2009 at 07:37:20PM -0600, Kim Phillips wrote:
> On Wed, 11 Feb 2009 19:26:22 +0100
> Heiko Schocher <hs at denx.de> wrote:
> 
> > +	switch (svid) {
> > +		case 0x0020:
> 
> 'case' should be aligned directly under 'switch'.
> 
> > +++ b/cpu/mpc83xx/start.S
> > @@ -137,6 +137,11 @@ get_pvr:
> >  	mfspr	r3, PVR
> >  	blr
> > 
> > +	.globl get_svr
> > +get_svr:
> > +	mfspr	r3, SVR
> > +	blr
> > +
> 
> on a ./MAKEALL SIMPC8313_LP, I'm getting:
> 
> powerpc-linux-gnu-ld: NAND bootstrap too big
> powerpc-linux-gnu-ld: NAND bootstrap too big
> make[1]: *** [/home/r1aaha/git/u-boot/nand_spl/u-boot-spl] Error 1
> make: *** [nand_spl] Error 2
> make: *** Waiting for unfinished jobs....
> powerpc-linux-gnu-size: './u-boot': No such file
> 
> and I think (because I haven't verified it), it's because of the above
> addition to start.S;  Can you please look into moving this fn elsewhere
> - see commit 455a4691 and test rebuilding the SIMPC board?

Seems like both get_pvr and get_svr should really be inline functions.

-Scott


More information about the U-Boot mailing list