[U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

Matthias Fuchs mfuchs at ma-fu.de
Wed Feb 18 07:46:54 CET 2009


Hi Stefan,
> On Tuesday 17 February 2009 15:19, Stefan Roese wrote:
> > On Sunday 15 February 2009, Matthias Fuchs wrote:
> > > This patch fixes coding style for PMC405 board support.
> > > Also some unneeded features/code is removed.
> > 
> > Please find some comments below.
> > 
> > > +	out32(GPIO0_TCR, CONFIG_SYS_FPGA_PRG | CONFIG_SYS_FPGA_CLK | \
> > > +	      CONFIG_SYS_FPGA_DATA | CONFIG_SYS_XEREADY);
> > 
> > I suggest to switch to using the out_be32()/in_be32() accessor functions 
> > instead. I am aware that many other 4xx boards still use the "wrong" accessor 
> > functions for initial GPIO configuration. I'll try to change this soon.
> 
> You are right I missed these. I will update the patch and resend.
> I will also fix the other esd boards in the next days.
please take a look at my 2nd patch ("Update PMC405 ...."). It does the
requested accessor fixes. So my first patch does nothing by style cleanup while
 the 2nd one brings some updates. I tried  not to mix up beautyfication with
functional code changes :-) So please keep these patches as they are :-)

Matthias


More information about the U-Boot mailing list