[U-Boot] [PATCH] 7/12 Multiadapter/multibus I2C, drivers part 4

[Wolfgang Denk]

Dear ksi at koi8.net,

In message <Pine.LNX.4.64ksi.0902181434310.5729 at home-gw.koi8.net> you wrote:
> 
> Yes, it is possible, but it is not the best approach. Most of those macros
...
> That means that implementation is much worse than _EXISTING_ one. And out of
> decent and much worse one which one would you choose?

Define "decent". It seems we have a different opintion abot such a
definition.

And define "much worse", please. How much wors is this (in bytes) for
a single adapter, and for 2, 3, or 5?

> > This is your implementation. It is not the  only  possible  implemen-
> > tation.  Please  try  and  open  your  mind  to  discuss  alternative
> > possibilities as well.
> 
> No, it is NOT my implementation. It is _EXISTING_ driver in the main tree. I
> did _NOT_ change the driver, I just made several copies of it.

Yes, and this is what I'm complaining about. The whole idea behind
software engineering is not to copy code.

> Well, it looks like it is you are Russian, not me :) It is well known

Maybe I am; kind of, at least :-)

> Russian passion to scrap everything and design a Universal Server Of
> Everything from scratch :) I'm trying to avoid that...

Me too.

> > Call it what you want, I call it duplication of code.
> 
> It might be a duplication of SOURCE TEXT, but not CODE.

Source text compiles to object code, doesn't it?

> > > > Is this theory or did you perform code size measurements?
> > > 
> > > It is obvious. Furthermore, it doesn't make sence to count size difference
> > > here because it is miniscule -- how many I2C adapters do we have on a board?
> > 
> > It is obvious. Famous last words again.
> 
> Eh, do you think anyone really has time to make such comparisons to find out
> that size difference is zero?

You have the code base ready available and can compile and measure
it, can't you?

If you base your argumentation on such claims, you better have prove
for it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: Why do PCs have a reset button on the front?
A: Because they are expected to run Microsoft operating systems.