[U-Boot] [PATCH] 9/12 Multiadapter/multibus I2C, configs part 2

Wolfgang Denk wd at denx.de
Thu Feb 19 21:40:53 CET 2009


Dear ksi at koi8.net,

In message <Pine.LNX.4.64ksi.0902171212360.30222 at home-gw.koi8.net> you wrote:
> 
> > Here again patches are split such that the resutling tree will not be
> > bisectable.
> 
> It looks like I didn't get you. Do you want me to make relatively small
> changes to 472 config files into 472 separate patches?

Being able to bisect means that after each single commit the source
tree has to be in a state that is at least compile clean, even better
actually working.

If you split a set of changes that belong to and depend on each other
into two commits, you will have a situation where  the  tree  doesn't
build  after the first (but before the second) commit. This is a PITA
when you use git-bisect to track down bugs in the code, so we try  to
avoid it whenever possible.

I don't care how many patches you use (as long as it's a resonable
number and a reasonabel size), but each of them must be bisectable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ein weiser Herrscher kann in einem großen Land  mehr  Gutes  bewirken
als  in  einem kleinen - ein dummer Herrscher aber auch viel mehr Un-
fug. Da weise Herrscher seltener sind als dumme, war ich schon  immer
gegen große Reiche skeptisch.                   - Herbert Rosendorfer


More information about the U-Boot mailing list