[U-Boot] [PATCH 2/6] Add FSL "Can use" framework

[Kim Phillips]

On Thu, 19 Feb 2009 20:56:50 +0100
Wolfgang Denk <wd at denx.de> wrote:

> Dear Anton Vorontsov,
> 
> In message <20090219154545.GB26618 at oksana.dev.rtsoft.ru> you wrote:
> > So far it's used for specifying whether we want to use FSL DR USB or
> > FSL eSDHC devices on MPC837X processors.
> > 
> > There are two more candidates for future use:
> > 1. USB ULPI PHY vs. TSEC1 on MPC8315E-RDB boards;
> > 2. Marvell vs. Vitesse PHYs on MPC8313E-RDB boards.

Isn't the marvell PHY detectable by s/w?

> > +	const char *usb_or_esdhc = getenv("usb_or_esdhc");
> 
> Please make it extendable, use a more generic name for one (and only
> one) environment variable. It makes littel sense to pollyte the
> envrionment with N additional variables. For example, call it
> "hwconfig". Allow that this variable holds a list of config settings,
> separated for example by comma or colon or ...

agreed - assuming this truly is indetectable by s/w.  Does "setenv
dip_sw_1_4 on" work more universally?

Kim