[U-Boot] [PATCH 2/7 v4] 83xx, kmeter1: add I2C, dtt, eeprom support

[Heiko Schocher]

Hello Kim,

Kim Phillips wrote:
> On Tue, 24 Feb 2009 11:30:34 +0100
> Heiko Schocher <hs at denx.de> wrote:
> 
>> diff --git a/board/keymile/kmeter1/kmeter1.c b/board/keymile/kmeter1/kmeter1.c
>> index f04a57a..a3c58ae 100644
>> --- a/board/keymile/kmeter1/kmeter1.c
>> +++ b/board/keymile/kmeter1/kmeter1.c
>> @@ -59,6 +59,23 @@ const qe_iop_conf_t qe_iop_conf_tab[] = {
>>  	{0,  0, 0, 0, QE_IOP_TAB_END},
>>  };
>>
>> +static int board_init_i2c_busses (void)
>> +{
>> +	I2C_MUX_DEVICE *dev = NULL;
>> +	uchar	*buf;
>> +
>> +	/* Set up the Bus for the DTTs */
>> +	buf = (unsigned char *) getenv ("dtt_bus");
> 
> Heiko, what am I missing here?  I thought any reference to environment
> pollution in the form of "dtt_bus" would have been gone by now.  Did we
> misunderstand each other here?  If its value changes between boards

Yes, I think so ...

> (and not boots), then there is no reason for this to be an environment
> variable.  No?

There is a reason, because if it is an environment variable, we (or better
the board manufacturer) can use one u-boot binary for all variants of
his hardware (as I said, they differ only in the i2c bus topology)

bye
Heiko

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany