[U-Boot] [PATCH 01/11] mkconfig: export ARCH, CPU, SOC, BOARD, VENDOR to config.h

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1235542278-21451-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  mkconfig |   32 +++++++++++++++++++++-----------
>  1 files changed, 21 insertions(+), 11 deletions(-)
> 
> diff --git a/mkconfig b/mkconfig
> index b0bbbd1..5ab9c2d 100755
> --- a/mkconfig
> +++ b/mkconfig
> @@ -62,25 +62,35 @@ if [ "$2" = "arm" ] ; then
>  fi
>  
>  #
> +# Create board specific header file
> +#
> +if [ "$APPEND" != "yes" ]	# Append to existing config file
> +then
> +	> config.h		# Create new config file
> +fi
> +
> +#

This is never necessary. Remove that.

>  # Create include file for Make
>  #
>  echo "ARCH   = $2" >  config.mk
> +echo "#define CONFIG_ARCH   $2" >>  config.h
>  echo "CPU    = $3" >> config.mk
> +echo "#define CONFIG_CPU    $3" >> config.h
>  echo "BOARD  = $4" >> config.mk
> +echo "#define CONFIG_BOARD  $4" >> config.h
> -[ "$5" ] && [ "$5" != "NULL" ] && echo "VENDOR = $5" >> config.mk
> +[ "$5" ] && [ "$5" != "NULL" ] && {
> +	echo "VENDOR = $5" >> config.mk
> +	echo "#define CONFIG_VENDOR $5" >> config.h
> +}

Please do NOT do this.

The setting up CONFIG_ options is done in the board config file, and
NOT in the Makefile.

This patch will cause conflicts with MANY boards.


Maybe you would like to explain WHY you are trying to do that?

NAK for now.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Madness takes its toll. Please have exact change.