[U-Boot] [PATCH/next branch] powerpc: Only use eth_getenv_enetaddr() if networking is enabled

Wolfgang Denk wd at denx.de
Wed Feb 25 10:16:53 CET 2009


Dear Stefan Roese,

In message <1235404365-3041-1-git-send-email-sr at denx.de> you wrote:
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>  lib_ppc/board.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/lib_ppc/board.c b/lib_ppc/board.c
> index f1b62f5..fc3cef6 100644
> --- a/lib_ppc/board.c
> +++ b/lib_ppc/board.c
> @@ -888,8 +888,10 @@ void board_init_r (gd_t *id, ulong dest_addr)
>  		bd->bi_ethspeed = 0xFFFF;
>  #endif
>  
> +#ifdef CONFIG_CMD_NET
>  	/* kept around for legacy kernels only ... ignore the next section */
>  	eth_getenv_enetaddr("ethaddr", bd->bi_enetaddr);
> +#endif
>  #ifdef CONFIG_HAS_ETH1
>  	eth_getenv_enetaddr("eth1addr", bd->bi_enet1addr);
>  #endif

Should that #ifdef not include the code for "eth1addr" etc., too?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Gates in my computer are AND, OR and NOT; they are not Bill.


More information about the U-Boot mailing list