[U-Boot] [PATCH/next branch] powerpc: Only use eth_getenv_enetaddr() if networking is enabled

Wolfgang Denk wd at denx.de
Wed Feb 25 11:54:18 CET 2009


Dear Stefan Roese,

In message <200902251029.42273.sr at denx.de> you wrote:
>
> > Should that #ifdef not include the code for "eth1addr" etc., too?
> 
> I don't think this is needed. If a board has a 2nd (or 3rd...) ethernet 
> interface, it sets CONFIG_HAS_ETH1. I can't think of a board setting this 
> define and not enabling CONFIG_CMD_NET.

Well, I can see such problems happen by accident - for example, when
you usualy have Ethernet enabled and just disable it for a test or to
shrink the image size or ...

> But if you prefer it, I could change the patch to include all eth interfaces 
> in the #ifdef CONFIG_CMD_NET part. Just let me know.

I think it would be cleaner, so please do. Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The POP3 server service depends on the SMTP  server  service,  which
failed to start because of the following error: The operation comple-
ted successfully."                         -- Windows NT Server v3.51


More information about the U-Boot mailing list