[U-Boot] [PATCH] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive

Mike Frysinger vapier at gentoo.org
Thu Jan 1 08:52:01 CET 2009


On Wednesday 31 December 2008 14:38:38 Wolfgang Denk wrote:
> In message <200812310242.57366.vapier at gentoo.org> you wrote:
> > > > +	    /* SanDisk Corporation U3 Cruzer Micro 1/4GB
> > > > +	     * Flash Drive 000016244373FFB4 */
> > > > +	    (dev->descriptor.idVendor =3D=3D 0x0781 &&
> > > > +	     dev->descriptor.idProduct =3D=3D 0x5406)
> > >
> > > Please fix multiline comment style.
> >
> > you'll have to be a little more specific as to what exactly you have
> > issues with.  comment looks fine to me.
>
> Maybe you should read the CodingStyle document, too?

no need to be jerkish about it.  the style you quote says "preferred".  it is 
not "required".  there are a ton of multiline comments added to the tree which 
do not strictly fit this format.  so rather than me trying to magically read 
your mind to figure out what you're taking issue with, it's simpler to ask.  
and for you to respond with something simple like "the trailing */ needs to be 
on its own line".  but of course i'm just guessing here.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090101/1289a89f/attachment.pgp 


More information about the U-Boot mailing list