[U-Boot] [PATCH v2] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive

Wolfgang Denk wd at denx.de
Thu Jan 1 14:53:05 CET 2009


Dear Mike Frysinger,

In message <200901010410.30775.vapier at gentoo.org> you wrote:
>
> > > +	    /* SanDisk Corporation U3 Cruzer Micro 1/4GB
> > > +	     * Flash Drive 000016244373FFB4
> > > +	     */
> >
> > Please fix the multiline comment style as described in the
> > CodingStyle document (substituting "preferred" by "required").
>
> please describe in actual words what is wrong with the comment.  it looks fine 
> to me.  then we can stop this pointless dance around literally nothing and get 
> back to doing real work.

I already quoted the relevant part of the Coding Style file. You would
do me and yourself a favour if you just read the document and my
messages instead of continuing to brawl.

In message <20081231193838.5DDF085AD247 at gemini.denx.de> I wrote:
...
>               /*
>                * This is the preferred style for multi-line
>                * comments in the Linux kernel source code.
>                * Please use it consistently.
>                *
>                * Description:  A column of asterisks on the left side,
>                * with beginning and ending almost-blank lines.
>                */

This is a pretty clear descriptiuon, and  a  clear  example.  If  you
still  don't  get  it,  I  cannot  help  you either. I have no better
explanation, and definitely not the time to continue arguing with you
on such a level.


Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lack of skill dictates economy of style.                - Joey Ramone


More information about the U-Boot mailing list