[U-Boot] [PATCH 2/5] ARM: Add/Improve support for Atmel AT91RM9200DK/E

[Ulf Samuelsson]

ons 2009-01-07 klockan 21:04 +0100 skrev Jean-Christophe
PLAGNIOL-VILLARD:
> On 20:55 Wed 07 Jan     , Ulf Samuelsson wrote:
> > ons 2009-01-07 klockan 02:11 +0100 skrev Jean-Christophe
> > PLAGNIOL-VILLARD:
> > > Ulf & Pink Boy
> > > 
> > > please take a look on
> > 
> > Thanks, I saw you committed part of the stuff I provided to the AT91
> > branch.
> > 
> > FYI: Your patch to at91rm9200dk, disabling the dataflash is wrong.
> > There is a 2 MB NOR flash *and* an 8 MB Dataflash on that board.
> > There is also a card connector allowing you to add an 
> > 8 MB dataflashcard as well.
> 
> I known it I've choose to disable to dataflash inthe mm branch for test on
> because I'm taking a look on the remove of the at45 driver to use the new
> spi flash framework
> and test the CFI driver
> 
> > The default operation of the board is to boot from the NOR
> > flash, but you can remove a resistor to allow booting 
> > from the dataflash.
> > 
> so the CFI will be the default config as you said the dataflash is an option
> > This is how my at91rm9200dk is configured.

It is the default for the AT91RM9200DK.


> > solderpads are even gone,so no way back to the parallel boot...
> > There is also a card connector allowing you to add an 
> > 8 MB dataflashcard as well.
> > 
> 
> > Most people I know of uses the AT91RM9200 with dataflash
> > so the support for the at91rm9200df board would be real nice
> > to have added ASAP.
> please do this via config not via a new board as we have done on the sam9
> 

There are more changes than selecting the dataflash instead of the 
nor flash so the addition to the Makefile could be long.
It is also meesy to change the configuration by a script
if it is in the Makefile.

I agree that you do not need any more board/atmel/<board>
directories. I think that it does not make sense
even to separate the 
board/atmel/at91rm9200dk and the
board/atmel/at91rm9200ek

With small changes to allow the MACHID to be set by the 
include/config file, the code can be the same.
In my last patchset all the 3 added boards use the
board/atmel/at91rm9200dk directory for the board files.

On the other hand, I think that we should
have a generic board support package that
allows selection of the any of the three supported
PHYs LXT971,BCM5251 and DM92161.
It should allow the user to provide the MACHID
in the include/configs/<board>.h


I do think it makes sense to have a separate
include/configs/at9rm9200df.h
to give some choices on what commands to implement

If possible, I would like to move the 
command activation to a separate file, which 
can be overwritten by a build system like openembedded
or buildroot.

Best Regards
Ulf Samuelsson


> Best Regards,
> J.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot