[U-Boot] [PATCH] MPC8349EMDS: do not setup unused PCI clock outputsin PCI agent mode

Ira Snyder iws at ovro.caltech.edu
Tue Jan 13 04:36:59 CET 2009


On Tue, Jan 13, 2009 at 08:09:23AM +0800, Liu Dave wrote:
> >  void pci_init_board(void)
> >  {
> >  	volatile immap_t *immr = (volatile immap_t *)CONFIG_SYS_IMMR;
> > -	volatile clk83xx_t *clk = (volatile clk83xx_t *)&immr->clk;
> >  	volatile law83xx_t *pci_law = immr->sysconf.pcilaw;
> >  	volatile pcictrl83xx_t *pci_ctrl = &immr->pci_ctrl[0];
> >  	struct pci_region *reg[] = { pci1_regions };
> >  
> > -	/* Enable all 8 PCI_CLK_OUTPUTS */
> > -	clk->occr = 0xff000000;
> > -	udelay(2000);
> 
> It will cause the PCI host broken. It needs case by case
> 

Yes, there are two pci_init_board() functions in this file. One for PCI
host mode, and one for PCI agent mode. This version only runs in agent
mode, it doesn't even get compiled in host mode.

It should be fine in host mode.

Thanks,
Ira


More information about the U-Boot mailing list