[U-Boot] [PATCH 07/11] flash/cfi_flash: Use virtual sector start address, not phys

Kumar Gala galak at kernel.crashing.org
Wed Jan 14 09:57:41 CET 2009


On Jan 14, 2009, at 2:38 AM, Kumar Gala wrote:

> Stefan,
>
> Have you reviewed this.  I'm not sure if remvoing the map_physmem() is
> the right answer because I'm assuming Haavard added them for a reason
> (AVR32?). Should we instead change info->start to be a phys_addr_t?
>
> - k

As I look at this we really need to understand what Haavard was trying  
to get with:

commit 12d30aa79779c2aa7a998bbae4c075f822a53004
Author: Haavard Skinnemoen <hskinnemoen at atmel.com>
Date:   Thu Dec 13 12:56:34 2007 +0100

     cfi_flash: Use map_physmem() and unmap_physmem()

     Use map_physmem() and unmap_physmem() to convert from physical to
     virtual addresses. This gives the arch a chance to provide an  
uncached
     mapping for flash accesses.

     Signed-off-by: Haavard Skinnemoen <hskinnemoen at atmel.com>

Since this only addresses the usage in cfi_flash.c but not in other  
users of flash_info (like commands)

- k


More information about the U-Boot mailing list