[U-Boot] [PATCH 0/5] ixp/npe: Move conditional compilation to Makefile
Wolfgang Denk
wd at denx.de
Thu Jan 22 08:46:31 CET 2009
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message <1232604438-15471-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
YOU DID IT AGAIN!!!
[PATCH 0/5] means DESCRIPTION only (and not a patch) for a patch
series consisyting of FIVE (5, as in .../5) patches. Nobody expects a
patch here, and nobody expects a 6 paret patch series here.
PLEASE STICK TO THE RULES!!!!
I hate it that I have to repeat this again and again to you!
> diff --git a/cpu/ixp/npe/Makefile b/cpu/ixp/npe/Makefile
> index 25117d7..aa664a1 100644
> --- a/cpu/ixp/npe/Makefile
> +++ b/cpu/ixp/npe/Makefile
> @@ -29,7 +29,7 @@ LOCAL_CFLAGS += -I$(TOPDIR)/cpu/ixp/npe/include -DCONFIG_IXP425_COMPONENT_ETHDB
> CFLAGS += $(LOCAL_CFLAGS)
> HOST_CFLAGS += $(LOCAL_CFLAGS)
>
> -COBJS := npe.o \
> +COBJS-$(CONFIG_IXP4XX_NPE) := npe.o \
> miiphy.o \
> IxOsalBufferMgt.o \
> IxOsalIoMem.o \
Given the fact that we don't have the needed npe files in the U-Boot
source tree, and that nobodu can legally include this because of the
licensing issues, should we not rather remove that code alltogether?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Half of the people in the world are below average.
More information about the U-Boot
mailing list