[U-Boot] [PATCH 3/5] ixp: move pci init in arm/board instead of cpu

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1232604438-15471-4-git-send-email-plagnioj at jcrosoft.com> you wrote:
> 
> +#if defined(CONFIG_CMD_PCI) || defined (CONFIG_PCI)
> +#include <pci.h>
> +static int arm_pci_init(void)
> +{
> +	pci_init();
> +	return 0;
> +}

Maybe pci_init() should return some error code?

> +# define INIT_FUNC_PCI_INIT arm_pci_init,
> +#else
> +# define INIT_FUNC_PCI_INIT
> +#endif /* CONFIG_CMD_PCI || CONFIG_PCI */

Ah, no, please don't.  That's not the way we do it in this file.

>  /*
>   * Breathe some life into the board...
>   *
> @@ -270,6 +282,7 @@ init_fnc_t *init_sequence[] = {
>  	init_func_i2c,
>  #endif
>  	dram_init,		/* configure available RAM banks */
> +	INIT_FUNC_PCI_INIT

Please stick with the style used elsewhere in this file (or change all
of it).


NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never put off until tomorrow what you can put off indefinitely.