[U-Boot] [PATCH 1/1] arm: fix some arch_number definition

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090122082908.GC15551 at game.jcrosoft.org> you wrote:
>
> > > -	/* arch number MACH_TYPE_ARMADILLO - not official*/
> > > -	gd->bd->bi_arch_number = 83;
> > > +	gd->bd->bi_arch_number = MACH_TYPE_ARMADILLO;
...
> > You actually CHANGE the arch_number here; you need the board
> > maintainer's ACK for such a patch.
> the ARMADILLO was changed in the current kernel it's not any more 83 but 615

I am aware of this. But anybody using some Linux kernel runnin on this board
will have a nasty surprise when hisl old kernels don;t boot any more
with recent versions of U-Boot.

This is why I request  that  you  ask  for  an  ACK  from  the  board
maintainer - he needs to be at least aware of such a change.

> > Note that there are other places where this is used - these must be
> > changed, too - for example:
> > 
> > "board/lpc2292sodimm/lpc2292sodimm.c":
> > 
> >  42         /* arch number MACH_TYPE_ARMADILLO - not official*/
> >  43         gd->bd->bi_arch_number = 83;
> I've not find it in the official list so I've let as 83 (non registered board)

You canged the old "MACH_TYPE_ARMADILLO" / 83 setting in one place but
not in others? This will cause inconsistent behaviour.

You must not do that.  Either leave ALL of these as they are, or fix
ALL of them in the SAME way.

> > > -	gd->bd->bi_arch_number = 234;
> > > +	gd->bd->bi_arch_number = MACH_TYPE_NS9750;
> > 
> > You actually CHANGE the arch_number here; you need the board
> > maintainer's ACK for such a patch.
> 234 is use for OMAP_INNOVATOR not the ns9750 so I've correct it
> 
> I any board maintainer have a problem with it I'm open

See above. You must talk to the board maintainers first.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Only two things are infinite,  the universe and human stupidity,  and
I'm not sure about the former.                     -- Albert Einstein