[U-Boot] [PATCH 1/2] net: Sort Makefile labels

Wolfgang Denk wd at denx.de
Sat Jan 24 02:00:17 CET 2009


Dear monstr at monstr.eu,

In message <d4fd46d3b2d27747b728da37fad3ebca3732d837.1231154122.git.monstr at monstr.eu> you wrote:
...
>  
>  COBJS-$(CONFIG_DRIVER_3C589) += 3c589.o
> +COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o
>  COBJS-$(CONFIG_DRIVER_AX88180) += ax88180.o

I have to admit that I rather sort this by the name of the CONFIG_
variable. Seeing "P" here between two "D"s looks strange to me.

Please don't do this.

>  COBJS-$(CONFIG_VSC7385_ENET) += vsc7385.o
>  COBJS-$(CONFIG_XILINX_EMAC) += xilinx_emac.o
>  COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o
> -COBJS-$(CONFIG_SH_ETHER) += sh_eth.o

Of course this is still wrong, like some others.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women,  and  en-
gineers.  While  the first two are more pleasant, the third is by far
the more certain."                      -- Baron Rothschild, ca. 1800


More information about the U-Boot mailing list