[U-Boot] [PATCH-OMAP3] OMAP3: Add Beagle Board and common power code

Wolfgang Denk wd at denx.de
Sun Jan 25 09:44:40 CET 2009


Dear Jason Kridner,

In message <1232853951-16767-1-git-send-email-jkridner at beagleboard.org> you wrote:
> QWRkIEJlYWdsZSBCb2FyZCBzdXBwb3J0IGFuZCBjb21tb24gcG93ZXIgY29kZSBmb3IgT01BUDMg
> Ym9hcmRzLgoKUmVzdHJ1Y3R1cmVkIGZyb20gcGF0Y2hlcyBieSBEaXJrIEJlaG1lIDxkaXJrLmJl
> aG1lQGdvb2dsZW1haWwuY29tPiwKU3RldmUgU2Frb21hbiA8c3RldmVAc2Frb21hbi5jb20+LCBh
> bmQgU8O4cmVuIFN0ZWVuIENocmlzdGVuc2VuCjxzb3JlbnNjaHJpc3RlbnNlbkBzdG9mYW5ldC5k
...

Please do NOT post base64 encoded patches.

Please post plain text only.

And post your stuff only once, not multiple times.

> --- /dev/null
> +++ b/board/omap3/beagle/beagle.h
...
> +#define MUX_BEAGLE() \
> + /*SDRC*/\
> + MUX_VAL(CP(SDRC_D0),		(IEN  | PTD | DIS | M0)) /*SDRC_D0*/\
> + MUX_VAL(CP(SDRC_D1),		(IEN  | PTD | DIS | M0)) /*SDRC_D1*/\
> + MUX_VAL(CP(SDRC_D2),		(IEN  | PTD | DIS | M0)) /*SDRC_D2*/\
> + MUX_VAL(CP(SDRC_D3),		(IEN  | PTD | DIS | M0)) /*SDRC_D3*/\
...

You probably want to indent this list.

> diff --git a/board/omap3/beagle/config.mk b/board/omap3/beagle/config.mk
> new file mode 100644
> index 0000000..c785011
> --- /dev/null
> +++ b/board/omap3/beagle/config.mk
> @@ -0,0 +1,35 @@
...
> +TEXT_BASE = 0x80e80000
> +
> +

Please no empty trailing lines. (Also check other files).


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Computers are not intelligent.  They only think they are.


More information about the U-Boot mailing list