[U-Boot] nand sector size is zero in jffs2 cmds

Derek Ou derek at siconix.com
Mon Jan 26 19:18:49 CET 2009


Hi, Wolfgang,

The following patch was tested some time ago.  I am in the middle of 
another task and can not
verify this patch with the latest code. Should I just reformat my patch 
and submit it or should I
wait till I can test it with the latest code?

Also, I found that jffs2 scanning routine does not skip the bad blocks 
in NAND in my
previous test.  Does anybody else see this behavior?

BTW, what is the best way to submit patches?  I tried git-format-patch 
approach described in
http://www.denx.de/wiki/U-Boot/GnatsEmail
But git-send-email is not easy to use.  I tried just copy and paste but 
thunderbird convert all the
tabs into spaces.  I ended up using copy and paste and webmail interface 
to send out another
patch.  But I will love to hear a better way of doing it.

Thanks,
Derek
Wolfgang Denk wrote:
> Dear Derek Ou,
>
> In message <49515BD6.9030606 at siconix.com> you wrote:
>   
>> The "### ERROR ### Please RESET the board ###" error and the zero NAND 
>> sector size problem can be fixed by the following patch.  However, the 
>> jffs2 scanning routine does not skip the bad blocks in NAND though.
>>
>> Derek
>> ************* patch **************
>> index 7866c80..f6966f3 100644
>> --- a/common/cmd_jffs2.c
>> +++ b/common/cmd_jffs2.c
>> @@ -1853,6 +1853,8 @@ int mtdparts_init(void)
>>                 if (part->size == SIZE_REMAINING)
>>                         part->size = id->size - part->offset;
>>  
>> +               part->sector_size = nand_info[id->num].erasesize;
>> +
>>                 DEBUGF("part  : name = %s, size = 0x%08lx, offset = 
>> 0x%08lx\n",
>>                                 part->name, part->size, part->offset);
>>     
> Can you please submit a proper patch (after fixing your mailer
> configuration which wraps long lines, thus corrupting the patch)?
>
> See http://www.denx.de/wiki/U-Boot/Patches for instructions.
>
> Best regards,
> Wolfgang Den


More information about the U-Boot mailing list