[U-Boot] [PATCH v2] Add 16bpp BMP support

Mark Jackson mpfj-list at mimc.co.uk
Tue Jan 27 13:21:18 CET 2009


Wolfgang Denk wrote:
> Dear Mark Jackson,

<snip>

> No, this still makes no sense to me. Listing all the accrhitectures
> where this is implemented or not is error prone, and this file should
> definitely be as independent from specific hardware properties as
> possible.
> 
> Can we not agree on some generic name (like CONFIG_BMP_16BPP) and
> #define this only on those boards that can do it / need it? Then we
> can omit all the "elif" ... lists.

Ah yes ... a much cleaner solution.

In fact, I guess there's no reason to #define any of this, since we're 
switching on the bpp anyway !!

What if I just remove all the extranous #defines all together ?  And just 
leave the inner "#if defined(CONFIG_ATMEL_LCD_BGR555)" ?

Regards
Mark


More information about the U-Boot mailing list