[U-Boot] [PATCH 1/1] arm: fix some arch_number definition

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Tue Jan 27 14:05:33 CET 2009


On 13:02 Tue 27 Jan     , Detlev Zundel wrote:
> Hi Jean-Christophe,
> 
> >> > > Note that there are other places where this is used - these must be
> >> > > changed, too - for example:
> >> > > 
> >> > > "board/lpc2292sodimm/lpc2292sodimm.c":
> >> > > 
> >> > >  42         /* arch number MACH_TYPE_ARMADILLO - not official*/
> >> > >  43         gd->bd->bi_arch_number = 83;
> >> > I've not find it in the official list so I've let as 83 (non registered board)
> >> 
> >> You canged the old "MACH_TYPE_ARMADILLO" / 83 setting in one place but
> >> not in others? This will cause inconsistent behaviour.
> >> 
> >> You must not do that.  Either leave ALL of these as they are, or fix
> >> ALL of them in the SAME way.
> > the other board are not a ARMODILLO correct if I wrong
> 
> Why not correct the wrong comment?  I think this is the consistent thing
> to do, as there certainly is no definition for "83" in the kernel and 83
> has nothing to do with ARMADILLO.
This make sense
anyway normaly no new arm board will not have a valid machine id now

Best Regards,
J.


More information about the U-Boot mailing list