[U-Boot] [PATCH 12/31] 82xx, mgcoge: corrected wrong flash sizes

Wolfgang Denk wd at denx.de
Wed Jan 28 13:01:54 CET 2009


Dear Heiko Schocher,

In message <498027D6.3070600 at denx.de> you wrote:
> flash size of mgcoge corrected
>  boot to  4M (was 32)
>  cfg  to 32M (was 64)
> 
> Signed-off-by: Thomas Herzmann <thomas.herzmann at keymile.com>
> Signed-off-by: Heiko Schocher <hs at denx.de>
> ---
>  include/configs/mgcoge.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/mgcoge.h b/include/configs/mgcoge.h
> index a754f0b..f307382 100644
> --- a/include/configs/mgcoge.h
> +++ b/include/configs/mgcoge.h
> @@ -99,14 +99,14 @@
> 
>  #define CONFIG_SYS_SDRAM_BASE		0x00000000
>  #define CONFIG_SYS_FLASH_BASE		0xFE000000
> -#define CONFIG_SYS_FLASH_SIZE		32
> +#define CONFIG_SYS_FLASH_SIZE		4

That's broken. The flash size should never be defined. Why don;t you
use auto-detection as U-Boot was designed for?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You know, after a woman's raised a family and so on,  she  wants  to
start living her own life."   "Whose life she's _been_ living, then?"
                                  - Terry Pratchett, _Witches Abroad_


More information about the U-Boot mailing list