[U-Boot] [PATCH 02/31] environment, netconsole: reducing packages when printing environment variables

[Wolfgang Denk]

Dear Stefan Roese,

In message <200901281256.14264.sr at denx.de> you wrote:
>
> > Check if printf() is not printing a series of single characters again!
> > Also, we tend to prefer using puts() / putc() over printf() because of
> > the huge performance overhead involved in printf() when only plain
> > constant strings need to be printed.
> 
> printf() is already used in the 2nd part of the patch. But the 1st string can 
> also be concat-ed of course and printed via puts(). printf() would be easier 
> to read though from my point of view.

Just because you are slow in one place (where you need the formatting
capabilities of printf()) is no excuse for being slow in other parts
(where you don't need it).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The two most common things in the universe are hydrogen  and  stupi-
dity."