[U-Boot] [PATCH 04/31] powerpc: 82xx serial: add configurable SMC Rx buffer len

[Wolfgang Denk]

Dear Heiko Schocher,

In message <498050AA.6070609 at denx.de> you wrote:
> 
> > We discussed this before. I explained that I do not want to have this
> > added level of complexity in the driver.
> > 
> > Why should I reconsider?
> 
> Hups, seems I missed something (Seems I stepped into this subject, after
> it was discussed here). I thought that you didnt want such a try, because
> it changes a driver that a lot of boards uses, and if this change is
> manageable it has a chance to get in mainline. Sorry, I have a look
> in the archives ...

Well, you can see that I actually reviewed the code. If there wasn;t
even a chance I would not have done that ;-)


> > How is this supposed to work?
> > 
> > Assume you set CONFIG_SYS_SMC_RXBUFLEN to 4, and the user at the
> > serial console port enters just a single character. When will the
> > receiver return this character? You might want to explain the
> > setup...
> 
> He will become this character when an idle-timout occurs. Then
> the SMC closes the buffer ...

So it would probably make sense to mention that  you  are  using  the
idle timeout now, right?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The whole world is about three drinks behind."     - Humphrey Bogart