[U-Boot] [PATCH 09/31] powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

Wolfgang Denk wd at denx.de
Wed Jan 28 14:17:05 CET 2009


Dear Heiko Schocher,

In message <49805339.8090802 at denx.de> you wrote:
> 
> > Why do you initialize these settins as 16 in patch N when you increase
> > the value in patch N+1? This makes little sense to me. Why not using
> > the right value right from the beginning?
> 
> Because it shows a development history.

I think it would be better to fold the second patch into the first
one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you are afraid of loneliness, don't marry."             - Chekhov


More information about the U-Boot mailing list