[U-Boot] [PATCH] Add support for the digsy MTC board.

[Wolfgang Denk]

Dear Grzegorz Bernacki,

In message <49816F40.3000201 at semihalf.com> you wrote:
>
> > General comment: there is a lot of code which could use a few comments
> > so the reader has a chance to understand what exactly you are doing.
> > 
> 
> Could you point me out which parts of code except eeprom defines needs
> more comments?

Hm... ther eare longish code sequences without a single line of
comment what you are doing, or why.

> >>   * This program is distributed in the hope that it will be useful,
> >>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
> >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> >>   * GNU General Public License for more details.
> >>   *
> >>   * You should have received a copy of the GNU General Public License
> > 
> > Please don't arbitrarily reformat the code.
> 
> I think this tab was inserted by mistake. In u-boot code there are both
> versions of license with and without this tab. Do you really want to 
> leave it?

The original form of the code has 2 spaces there, as  usual  after  a
full  stop. It seems this file has been run through "unexpand -a" (or
an equivalent command), which inserted  a  TAB  instead  of  the  two
spaces.  This seems no problem to me, as the text still looks exactly
the same (and we same one byte of disk storage :-).

Your patch makes the text look different, and the change is to the
worse.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The light at the end of the tunnel is usually a "No Exit" sign.