[U-Boot] [PATCH] Add support for the digsy MTC board.

[Jerry Van Baren]

Wolfgang Denk wrote:
> Dear Grzegorz Bernacki,
> 
> In message <49816F40.3000201 at semihalf.com> you wrote:

[snip]

>>>>   * This program is distributed in the hope that it will be useful,
>>>>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>>>   * GNU General Public License for more details.
>>>>   *
>>>>   * You should have received a copy of the GNU General Public License
>>> Please don't arbitrarily reformat the code.
>> I think this tab was inserted by mistake. In u-boot code there are both
>> versions of license with and without this tab. Do you really want to 
>> leave it?
> 
> The original form of the code has 2 spaces there, as  usual  after  a
> full  stop. It seems this file has been run through "unexpand -a" (or
> an equivalent command), which inserted  a  TAB  instead  of  the  two
> spaces.  This seems no problem to me, as the text still looks exactly
> the same (and we same one byte of disk storage :-).

Ahh, but two spaces vs. one tab have different meanings.  They just 
happen to look the same at the moment (blithely ignoring the fact that 
this particular line of text isn't likely to change).

IMHO, replacing the two spaces with a tab was inadvertent whitespace 
damage apparently due to a whitespace cleanup and should be fixed back 
to being two spaces in all the header files.

> Your patch makes the text look different, and the change is to the
> worse.
> 
> Best regards,
> 
> Wolfgang Denk

Painting the bike shed,
gvb