[U-Boot] [PATCH 01/27 v2] Blackfin: bfin_mac: force board_get_enetaddr() usage

Wolfgang Denk wd at denx.de
Thu Jan 29 20:03:36 CET 2009


Dear Mike Frysinger,

In message <200901291135.32632.vapier at gentoo.org> you wrote:
>
> the driver isnt really generic.  it's specific to the hardware that exists 
> inside of Blackfin chips.  the hardware has no support at all for storing the 

Well, the same applies for many other Ethernet drivers as well, be it
the FEC ethernet driver for the MPC8xx, the FCC for the MPC82xx or the
TSEC for the 8xxx, etc.

> what you propose wouldnt have been possible before, but with Ben's work it 
> should be easy to move to board_eth_init().

So lat's do this, then, please.

> as for generic code, i'd point out that lib_ppc/board.c is a much worse 
> offender in this regard ...

I take this as an indication that we can learn from errors made in
the past, instead of repeating them.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You know, after a woman's raised a family and so on,  she  wants  to
start living her own life."   "Whose life she's _been_ living, then?"
                                  - Terry Pratchett, _Witches Abroad_


More information about the U-Boot mailing list