No subject

Involve the __udelay() may not suitable for the timer functions...

>
> ...
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-pantheon/config.h
>> @@ -0,0 +1,44 @@
> ...
>> +/*
>> + * There is no internal RAM in ARMADA100, using DRAM
>> + * TBD: dcache to be used for this
>> + */
>> +#define CONFIG_SYS_INIT_SP_ADDR =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0(CONFIG_SYS_TEXT_BASE - 0x00200000)
>> +#define CONFIG_NR_DRAM_BANKS_MAX =C2=A0 =C2=A0 2
>
> This looks like board specific code that should not be here.

Yep... I would update the patch for it. For V7...

>
> ...
>> +struct panthmpmu_registers {
>> + =C2=A0 =C2=A0 u8 pad0[0x0024];
>> + =C2=A0 =C2=A0 u32 ccgr; =C2=A0 =C2=A0 =C2=A0 /*0x0024*/
>> + =C2=A0 =C2=A0 u8 pad1[0x0200 - 0x024 - 4];
>> + =C2=A0 =C2=A0 u32 wdtpcr; =C2=A0 =C2=A0 /*0x0200*/
>> + =C2=A0 =C2=A0 u8 pad2[0x1020 - 0x200 - 4];
>> + =C2=A0 =C2=A0 u32 aprr; =C2=A0 =C2=A0 =C2=A0 /*0x1020*/
>> + =C2=A0 =C2=A0 u32 acgr; =C2=A0 =C2=A0 =C2=A0 /*0x1024*/
>> +};
>
> Please use TAB for vertical alignment of variable names. =C2=A0Please fix
> globally.

In V6 patch , I think I already do like using tab. :)


Best regards,
Lei