No subject


Fri Jan 23 11:48:37 CET 2009


could perhaps move the last ones up into the main area, to avoid the
new code in image_check_image_types().

Also I don't think the #ifdef really helps here, except perhaps for
testing that you haven't left something bad in the code. It might be
better to display an error like 'relative images not supported' when
CONFIG_SYS_RELATIVE_IMAGES is not defined.

> @@ -372,10 +384,25 @@ image_get_hdr_l(magic) =A0 =A0 =A0 =A0 =A0 =A0/* im=
age_get_magic */
> =A0image_get_hdr_l(hcrc) =A0 =A0 =A0 =A0 =A0/* image_get_hcrc */
> =A0image_get_hdr_l(time) =A0 =A0 =A0 =A0 =A0/* image_get_time */
> =A0image_get_hdr_l(size) =A0 =A0 =A0 =A0 =A0/* image_get_size */
> -image_get_hdr_l(load) =A0 =A0 =A0 =A0 =A0/* image_get_load */
> -image_get_hdr_l(ep) =A0 =A0 =A0 =A0 =A0 =A0/* image_get_ep */
> +image_get_hdr_l(load_raw) =A0 =A0 =A0/* image_get_load_raw */
> +image_get_hdr_l(ep_raw) =A0 =A0 =A0 =A0/* image_get_ep_raw */

might need another tab here (although it isn't visible on email)

> @@ -430,8 +457,8 @@ image_set_hdr_l(magic) =A0 =A0 =A0 =A0 =A0 =A0 =A0/* =
image_set_magic */
> =A0image_set_hdr_l(hcrc) =A0 =A0 =A0 =A0 =A0/* image_set_hcrc */
> =A0image_set_hdr_l(time) =A0 =A0 =A0 =A0 =A0/* image_set_time */
> =A0image_set_hdr_l(size) =A0 =A0 =A0 =A0 =A0/* image_set_size */
> -image_set_hdr_l(load) =A0 =A0 =A0 =A0 =A0/* image_set_load */
> -image_set_hdr_l(ep) =A0 =A0 =A0 =A0 =A0 =A0/* image_set_ep */
> +image_set_hdr_l(load_raw) =A0 =A0 =A0/* image_set_load_raw */
> +image_set_hdr_l(ep_raw) =A0 =A0 =A0 =A0/* image_set_ep_raw */

might need another tab here (although it isn't visible on email)

Regards,
Simon


More information about the U-Boot mailing list