[U-Boot] [PATCH] arm: Kirkwood: Add memory barriers to kwgbe_send/recv

[Prafulla Wadaskar]

> -----Original Message-----
> From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net] 
> Sent: Thursday, July 02, 2009 12:17 PM
> To: Prafulla Wadaskar
> Cc: U-Boot ML
> Subject: Re: [U-Boot] [PATCH] arm: Kirkwood: Add memory 
> barriers to kwgbe_send/recv
> 
> On Wed, 1 Jul 2009 09:57:10 -0700
> Prafulla Wadaskar <prafulla at marvell.com> wrote:
> > > kwgbe_send/recv both have loops waiting for the hardware 
> to set  a 
> > > bit.
> > > GCC 4.3.3 cleverly optimizes this to ... a while(1); loop.
> > Struct used is defined as volatile here.
> > Is this not sufficient?
> 
> Right, but that was only for recv - send isn't volatile. I'll 
> send a new patch with the required changes. The question is which :-):
> 
> 1. Make structure volatile in send as well
Hi Simon
I suggest to implement this change

Regards..
Prafulla . .