[U-Boot] [PATCH v3] sf: Macronix additional chips supported

Mike Frysinger vapier at gentoo.org
Mon Jul 6 08:48:27 CEST 2009


On Monday 06 July 2009 07:41:52 Prafulla Wadaskar wrote:
> +	u16 id = (u16 *) *idcode;

sorry, this wont fly on systems that cannot do unaligned accesses.  i dont 
know the status of the get_unaligned() type macros in u-boot, but it'll 
probably be easier to just do:
idcode[0] | idcode[1] << 8;

> -		if (params->idcode1 == idcode[2])
> +                if (params->idcode == id)
> -		debug("SF: Unsupported Macronix ID %02x\n", idcode[1]);
> +                debug("SF: Unsupported Macronix ID %04x\n", id);

you've still got busted whitespace here :/
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090706/5ae0ebb0/attachment-0001.pgp 


More information about the U-Boot mailing list