[U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants

[Wolfgang Denk]

Dear Stefan Roese,

In message <1246873688-25113-1-git-send-email-sr at denx.de> you wrote:
> Until now these defines were only enabled for the PPC440 variants. This
> patch now defines CONFIG_SYS_64BIT_VSPRINTF and CONFIG_SYS_64BIT_STRTOUL
> on PPC40x now as well. This removes the compilation warning with the new
> updated NAND code.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>  include/ppc4xx.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/ppc4xx.h b/include/ppc4xx.h
> index 55ff323..d9f04f7 100644
> --- a/include/ppc4xx.h
> +++ b/include/ppc4xx.h
> @@ -109,13 +109,14 @@
>  
>  #endif /* 440EP/EPX 440GR/GRX 440SP/SPE 460EX/GT/SX 405EX*/
>  
> -#if defined(CONFIG_440)
>  /*
>   * Enable long long (%ll ...) printf format on 440 PPC's since most of
>   * them support 36bit physical addressing
>   */
>  #define CONFIG_SYS_64BIT_VSPRINTF
>  #define CONFIG_SYS_64BIT_STRTOUL
> +
> +#if defined(CONFIG_440)
>  #include <ppc440.h>
>  #else
>  #include <ppc405.h>

NAK.

This needs to be cleaned up, but differently. Sorry that I did not
catch this earlier - it seems the related code was introduced by
commit f2302d44 (which sailed under the innocent title "Fix merge
problems").

Please move these CONFIG_SYS_* settings out of this file.

For me it is not acceptable to set configuration options in global
header files like include/ppc4xx.h; CONFIG_* settings are supposed to
be selected by the board configuration files, and only there.

I hope we don't have any more such #defines hidden in other header
files?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Research is what I'm doing when I don't know what I'm doing.
                                                 -- Wernher von Braun