[U-Boot] [PATCH v4 3/6] ARM: Add macros.h to be used in assembler file.

Wolfgang Denk wd at denx.de
Tue Jul 7 21:33:16 CEST 2009


Dear Magnus Lilja,

In message <6fd22327241accc2efcada8380923c8e9c523790.1244918138.git.lilja.magnus at gmail.com> you wrote:
> Changes from last version: Added documentation for the macros.
> 
>  include/asm-arm/macro.h |   74 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 74 insertions(+), 0 deletions(-)
>  create mode 100644 include/asm-arm/macro.h

Sorry for the late comment...

...
> +/*
> + * These macros provide a convenient way to write 8, 16 and 32 bit data
> + * to any address.

I think this comment might be wrong. It should probably read "...  to
any  _memory_ address". Using these macros to access device registers
and the like is probably nore recommended?

Please comment...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: What do you get when you cross an ethernet with an income statement?
A: A local area networth.


More information about the U-Boot mailing list