[U-Boot] [PATCH v3 3/3] A320: Add support for Faraday A320 evaluation board

[Po-Yu Chuang]

Dear Wolfgang Denk,

2009/7/9 Wolfgang Denk <wd at denx.de>:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -680,6 +680,10 @@ Sergey Lapin <slapin at ossfans.org>
>>
>>       afeb9260        ARM926EJS (AT91SAM9260 SoC)
>>
>> +Po-Yu Chuang <ratbert at faraday-tech.com>
>> +
>> +     a320            FA526 (ARMv4/reuse arm920t source) faraday SoC
>
> Please keep list of maintainers alphabetically sorted.

What is the key for sorting? I cannot figure it out.

>> --- a/Makefile
>> +++ b/Makefile
>> @@ -2991,6 +2991,13 @@ B2_config      :       unconfig
>>       @$(MKCONFIG) $(@:_config=) arm s3c44b0 B2 dave
>>
>>  #########################################################################
>> +## Faraday A320 Systems
>> +#########################################################################
>
> We don't add such big headers for all vendors.

OK, removed.

>> +a320_config  :       unconfig
>> +     @$(MKCONFIG) $(@:_config=) arm arm920t a320 faraday faraday
>
> This is a arm920t processor, so please add it in "ARM720T Systems"
> section.
>
>> +#########################################################################
>>  ## ARM720T Systems
>>  #########################################################################

720t?
How about integrator section? Many 920t boards are there.

########################################################################
## ARM Integrator boards - see doc/README-integrator for more info.

>> diff --git a/board/faraday/a320/a320.c b/board/faraday/a320/a320.c
>> new file mode 100644
>> index 0000000..f9cca4f
>> --- /dev/null
>> +++ b/board/faraday/a320/a320.c
...
>> +int dram_init (void)
>> +{
>> +     gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>> +     gd->bd->bi_dram[0].size  = PHYS_SDRAM_1_SIZE;
>> +
>> +     return 0;
>> +}
>
> Would it be possible to use get_ram_size() for auto-sizing and memory
> testing?

OK, I'll try.

>> diff --git a/board/faraday/a320/lowlevel_init.S
>> b/board/faraday/a320/lowlevel_init.S
>> new file mode 100644
>> index 0000000..2adb9ef
>> --- /dev/null
>> +++ b/board/faraday/a320/lowlevel_init.S
...
>> +copy_code:
>> +     ldr     r0, =ROM_DEFAULT_BASE   /* r0 <- source address     */
>> +     ldr     r1, =SDRAM_DEFAULT_BASE /* r1 <- target address     */
>> +
>> +     ldr     r2, .LC5
>> +     ldr     r3, .LC6
>> +     sub     r2, r3, r2              /* r2 <- size of armboot            */
>
> Please use TABs for vertical alignment.
>

Spaces removed.

>> diff --git a/cpu/arm920t/faraday/timer.c b/cpu/arm920t/faraday/timer.c
>> new file mode 100644
>> index 0000000..7762012
>> --- /dev/null
>> +++ b/cpu/arm920t/faraday/timer.c
...
>> +#undef DEBUG
>
> Please do not add dead code.
>
removed

...
>> +static volatile struct fttmr010 *tmr = (struct fttmr010 *)CONFIG_SYS_TIMERBASE;
>> +static volatile struct ftpmu010 *pmu = (struct ftpmu010
>> *)CONFIG_SYS_FTPMU_BASE;
>
> Bad formatting here?

I will use git send-email next time to avoid this. Thanks.

best regards,
Po-Yu Chuang