[U-Boot] [PATCH] ppc4xx: Move 405EP pci code from cpu_init_f() to __pci_pre_init()

Stefan Roese sr at denx.de
Fri Jul 10 09:01:08 CEST 2009


On Wednesday 08 July 2009 13:43:55 Matthias Fuchs wrote:
> This patch moves some basic PCI initialisation from the 4xx cpu_init_f()
> to cpu/ppc4xx/4xx_pci.c.
>
> The original cpu_init_f() function enabled the 405EP's internal arbiter
> in all situations. Also the HCE bit in cpc0_pci is always set.
> The first is not really wanted for PCI adapter designs and the latter
> is a general bug for PCI adapter U-Boots. Because it enables
> PCI configuration by the system CPU even when the PCI configuration has
> not been setup by the 405EP. The one and only correct place is
> in pci_405gp_init() (see "Set HCE bit" comment).
>
> So for compatibility reasons the arbiter is still enabled in any case,
> but from weak pci_pre_init() so that it can be replaced by board specific
> code.
>
> Signed-off-by: Matthias Fuchs <matthias.fuchs at esd.eu>

Applied to u-boot-ppc4xx. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list